Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: fix badge image and pkg.go.dev link URLs in badge generation tool #40216

Closed
jamalc opened this issue Jul 14, 2020 · 2 comments
Closed

x/pkgsite: fix badge image and pkg.go.dev link URLs in badge generation tool #40216

jamalc opened this issue Jul 14, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@jamalc
Copy link

jamalc commented Jul 14, 2020 •
edited

What did you do?

Generating badges using the badge generation tool (https://pkg.go.dev/badge).

For example, generating a badge for the URL:

https://pkg.go.dev/net/url?tab=overview

What did you expect to see?

It should produce the following markdown snippet:

[![PkgGoDev](https://pkg.go.dev/badge/net/url?tab=overview)](https://pkg.go.dev/net/url?tab=overview)

What did you see instead?

And instead produces this snippet:

[![PkgGoDev](https://pkg.go.dev/net/url?tab=overview)](https://pkg.go.dev/badge/net/url?tab=overview)
@jamalc jamalc added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jul 14, 2020
@jamalc jamalc self-assigned this Jul 14, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2020
@gopherbot
Copy link

Change https://golang.org/cl/242641 mentions this issue: content,internal: fix markdown badge snippet

@jamalc jamalc mentioned this issue Jul 14, 2020
Closed
@jamalc jamalc reopened this Jul 15, 2020
@gopherbot
Copy link

Change https://golang.org/cl/242737 mentions this issue: content/static: fix badge dynamic update

@golang golang locked and limited conversation to collaborators Jul 15, 2021
@rsc rsc unassigned jamalc Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @jamalc