Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: improve -dry-run -mode=prepare to support advance testing for more release types #40214

Closed
dmitshur opened this issue Jul 14, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 14, 2020

Right now, it's possible to use releasebot -dry-run -mode=prepare (notably, with -dry-run flag) to run a release locally that doesn't publish any public artifacts, but only for the beta release type (e.g., go1.15beta2).

For most other release types, it fails "too early" to produce useful information. For example, it doesn't take into account that the Gerrit CL updating the VERSION file isn't actually mailed, so trying to fetch its commit hash from Gerrit will give 404, and release won't be able to proceed.

This is the tracking issue about improving that, so fewer ad-hoc changes need to be made to releasebot each time this ability is needed. It's broken out of #29252 (comment).

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 14, 2020
@dmitshur dmitshur added this to the Unreleased milestone Jul 14, 2020
@dmitshur
Copy link
Contributor Author

dmitshur commented Aug 3, 2022

releasebot has been superseded by relui and this issue doesn't apply directly. relui has a "dry-run (test and build only): ..." workflows for testing, and #47407 is for more. Closing.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Aug 3, 2022
@dmitshur dmitshur added this to Done in Go Release Team Aug 3, 2022
@golang golang locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Archived in project
Development

No branches or pull requests

2 participants