Skip to content

x/pkgsite: TestFetchModule/stdlib_module failing #40197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amarjeetanandsingh opened this issue Jul 14, 2020 · 2 comments
Closed

x/pkgsite: TestFetchModule/stdlib_module failing #40197

amarjeetanandsingh opened this issue Jul 14, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@amarjeetanandsingh
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.13.4 darwin/amd64

Does this issue reproduce with the latest release?

YES.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/amar/Library/Caches/go-build"
GOENV="/Users/amar/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/amar/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/amar/oss/pkgsite/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/nr/2l1z8c_152s8x6tsb9xsb4t40000gq/T/go-build178565033=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

./all.bash

What did you expect to see?

To pass all the testcases.

What did you see instead?

TestFetchModule/stdlib_module failed with following message

--- FAIL: TestFetchModule (1.92s)
    --- FAIL: TestFetchModule/stdlib_module (0.14s)
        fetch_test.go:110: mismatch (-want +got):
              &fetch.FetchResult{
              	ModulePath:       "std",
              	RequestedVersion: "v1.12.5",
              	ResolvedVersion:  "v1.12.5",
            - 	GoModPath:        "",
            + 	GoModPath:        "std",
              	Status:           200,
              	Error:            nil,
              	... // 2 identical fields
              }
@gopherbot gopherbot added this to the Unreleased milestone Jul 14, 2020
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/242417 mentions this issue: internal/fetch: fix the TestFetchModule/stdlib_module

@amarjeetanandsingh
Copy link
Contributor Author

Thanks @julieqiu for the fix

@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. labels Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @amarjeetanandsingh