Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: handle queries with https:// and http:// scheme(strip schemes from searches) #40141

Closed
epelc opened this issue Jul 10, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone

Comments

@epelc
Copy link

epelc commented Jul 10, 2020

What did you do?

Go to pkg site and search https://github.com/godbus/dbus.

https://pkg.go.dev/

Doesn't work with scheme:

https://pkg.go.dev/search?q=https%3A%2F%2Fgithub.com%2Fgodbus%2Fdbus

Works without scheme:

https://pkg.go.dev/github.com/godbus/dbus?tab=doc

PS I am aware package names do not include the scheme. This is more an ease of use search feature.

What did you expect to see?

Results for github.com/godbus/dbus

What did you see instead?

404 page

I believe https:// and http:// should automatically be stripped from queries. You should be able to easily copy a url from a repo site like github and paste into the search without modifying for projects which don't have a doc link setup. This is very common and should be handled automatically.

@gopherbot gopherbot added this to the Unreleased milestone Jul 10, 2020
@dmitshur
Copy link
Contributor

/cc @julieqiu per owners.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2020
@jba
Copy link
Contributor

jba commented Sep 15, 2020

Dup of #41095.

@jba jba closed this as completed Sep 15, 2020
@golang golang locked and limited conversation to collaborators Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants