Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mobile/cmd/gomobile: test failed w/ "Apple Development" certificate #40134

Closed
hajimehoshi opened this issue Jul 9, 2020 · 6 comments
Closed

x/mobile/cmd/gomobile: test failed w/ "Apple Development" certificate #40134

hajimehoshi opened this issue Jul 9, 2020 · 6 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@hajimehoshi
Copy link
Member

Now building an iOS app requires "iPhone Developer" certification.

https://github.com/golang/mobile/blob/33b80540585f2b31e503da24d6b2a02de3c53ff5/cmd/gomobile/build_iosapp.go#L157-L160

I'm not confident, but should "Apple Development" certification also work?

CC @hyangah @eliasnaur
@gopherbot gopherbot added the mobile Android, iOS, and x/mobile label Jul 9, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 9, 2020
@eliasnaur
Copy link
Contributor

FWIW, Gio doesn't hardcode the certificate name; rather, it finds the certificate matching the app ID:

https://git.sr.ht/~eliasnaur/gio/tree/master/cmd/gogio/iosbuild.go#L80

@dmitshur
Copy link
Contributor

dmitshur commented Jul 9, 2020

I've run into this too when investigating iOS support recently, and temporarily changed to "Apple Development" locally. I haven't followed up on that yet, but just wanted to add a data point.

@hajimehoshi
Copy link
Member Author

@dmitshur Thanks. Do you think checking "Apple Development" as fallback would make sense?

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jul 11, 2020
@hajimehoshi
Copy link
Member Author

ping @dmitshur

@changkun
Copy link
Member

changkun commented Sep 2, 2021

This should also be fixed in CL 346151. We can close it directly.

(Sorry again for not referring to it directly in the CL.)

cc @hajimehoshi

@hajimehoshi
Copy link
Member Author

Thanks!

@golang golang locked and limited conversation to collaborators Sep 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@hajimehoshi @eliasnaur @dmitshur @changkun @gopherbot