Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add function to set up test queue #40098

Closed
julieqiu opened this issue Jul 7, 2020 · 6 comments
Closed

x/pkgsite: add function to set up test queue #40098

julieqiu opened this issue Jul 7, 2020 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Jul 7, 2020

There are a couple of places in the code where we want to set up a queue for testing:

It would be useful to have a single setupQueue function for use in testing.
@julieqiu julieqiu added Suggested Issues that may be good for new contributors looking for work to do. help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jul 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 7, 2020
@tayoogunbiyi
Copy link

It would be useful to have a single setupQueue function for use in testing.

The link for where the code is duplicated within internal/testing/integration/frontend_test.go is https://github.com/golang/pkgsite/blob/master/internal/testing/integration/frontend_test.go#L205-L211

@amarjeetanandsingh
Copy link
Contributor

@julieqiu
May I give it a try?

@julieqiu
Copy link
Member Author

@amarjeetanandsingh please do!

@BLasan
Copy link

BLasan commented Aug 5, 2020

@julieqiu Can I work on this?

@julieqiu julieqiu removed the website label Sep 19, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@ya5u
Copy link

ya5u commented Jan 30, 2021

@julieqiu queue.InMemory seems to be working effectively as a test helper and to be invoked by no other than test code. Isn't it necessary to create another function?

@julieqiu
Copy link
Member Author

julieqiu commented Feb 2, 2021

Nope - this issue seems to be outdated. Thanks for taking a look!

@julieqiu julieqiu closed this as completed Feb 2, 2021
@golang golang locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
6 participants
@julieqiu @gopherbot @amarjeetanandsingh @ya5u @tayoogunbiyi @BLasan