Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add function to set up queue #40097

Closed
julieqiu opened this issue Jul 7, 2020 · 3 comments
Closed

x/pkgsite: add function to set up queue #40097

julieqiu opened this issue Jul 7, 2020 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Unreleased

Comments

@julieqiu
Copy link
Member

julieqiu commented Jul 7, 2020

We use the same newQueue logic in cmd/frontend and cmd/worker:

It would be nice to have a single function to reduce duplication.
@julieqiu julieqiu added Suggested Issues that may be good for new contributors looking for work to do. help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jul 7, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jul 7, 2020
@akolar
Copy link

akolar commented Jul 7, 2020

Mind if I take a stab at this?

@julieqiu
Copy link
Member Author

julieqiu commented Jul 7, 2020

Please do!

@gopherbot
Copy link

Change https://golang.org/cl/241477 mentions this issue: internal/queue: refactor existing queue creators into queue.New

@golang golang locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@julieqiu @akolar @gopherbot