Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http/httputil: TestReverseProxyFlushInterval failing #4009

Closed
davecheney opened this issue Aug 27, 2012 · 11 comments
Closed

net/http/httputil: TestReverseProxyFlushInterval failing #4009

davecheney opened this issue Aug 27, 2012 · 11 comments
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@davecheney
Copy link
Contributor

What steps will reproduce the problem?

reported by fullung on issue #3892.

After applying 6483061 issue #3892 is resolved, but another issue replaces it 

What is the expected output? What do you see instead?

expected: PASS

actual: with enough time and random GOMAXPROCS TestReverseProxyFlushInterval will fail.

=== RUN TestReverseProxyFlushInterval-59
--- FAIL: TestReverseProxyFlushInterval-59 (5.00 seconds)
reverseproxy_test.go:191: maxLatencyWriter flushLoop() never exited
FAIL

Initial investigations lead me to suspect
http://code.google.com/p/go/source/browse/src/pkg/net/http/httputil/reverseproxy_test.go#170
is not being published correctly so
http://code.google.com/p/go/source/browse/src/pkg/net/http/httputil/reverseproxy.go#175
does not observe its value has changed.

Please use labels and text to provide additional information.
@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 2:

Labels changed: added go1.1maybe.

@rsc
Copy link
Contributor

rsc commented Mar 12, 2013

Comment 3:

[The time for maybe has passed.]

Labels changed: removed go1.1maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 4:

Labels changed: added go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Sep 10, 2013

Comment 5:

Labels changed: added testing.

@rsc
Copy link
Contributor

rsc commented Oct 2, 2013

Comment 6:

Labels changed: added go1.3, removed go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 7:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 8:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 9:

Labels changed: added repo-main.

@ianlancetaylor
Copy link
Contributor

Comment 10:

Is this still a problem?

@bradfitz
Copy link
Contributor

Comment 11:

Labels changed: removed release-go1.3.

Status changed to TimedOut.

@davecheney davecheney added timedout Testing An issue that has been verified to require only test changes, not just a test failure. labels Apr 14, 2014
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

5 participants