Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: include GOMODCACHE in documented list of environment variables #40089

Closed
dmitshur opened this issue Jul 7, 2020 · 3 comments
Closed

cmd/go: include GOMODCACHE in documented list of environment variables #40089

dmitshur opened this issue Jul 7, 2020 · 3 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.15

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 7, 2020

Go 1.15 adds the GOMODCACHE environment variable (#34527). It's mentioned in the release notes (CL 230537). Should it also be included in the list at https://tip.golang.org/cmd/go/#hdr-Environment_variables?

/cc @jayconrod @matloob @bcmills
@dmitshur dmitshur added Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 7, 2020
@dmitshur dmitshur added this to the Go1.15 milestone Jul 7, 2020
@tpaschalis
Copy link
Contributor

If it's included, would it go under General-purpose environment variables? Could I suggest something like

GOMODCACHE
	The directory where the go command will cache module downloads. 
	It defaults to GOPATH/pkg/mod.

@jayconrod jayconrod self-assigned this Jul 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/241275 mentions this issue: cmd/go: include GOMODCACHE in 'go help environment'

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 8, 2020
@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 9, 2020

There's a CL out to fix this (that just needs review), I think we don't want to release Go 1.15 without this, so marking release-blocker so this isn't missed by accident.

@golang golang locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
4 participants
@jayconrod @dmitshur @gopherbot @tpaschalis