Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: standard library packages should not use upper-case paths #40065

Closed
rsc opened this issue Jul 6, 2020 · 4 comments
Closed

all: standard library packages should not use upper-case paths #40065

rsc opened this issue Jul 6, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.15

Comments

@rsc
Copy link
Contributor

rsc commented Jul 6, 2020

crypto/x509/internal/macOS was added on May 7.
It is the first standard library package with upper-case letters.
They should be lowercased, following the standard all-lower-case convention.
(For example it is syscall/internal/windows not syscall/internal/Windows.)

I believe this is the only one, but if there are others, they should be fixed too.
@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jul 6, 2020
@rsc rsc added this to the Go1.15 milestone Jul 6, 2020
@crawshaw
Copy link
Member

crawshaw commented Jul 6, 2020

Two other directories but they are not actual packages:

find . -type d -name "*[A-Z]*"
./cmd/link/testdata/testIndexMismatch
./cmd/link/testdata/testBuildFortvOS
./crypto/x509/internal/macOS

@robpike robpike changed the title all: standard library packages should not use upper-case all: standard library packages should not use upper-case paths Jul 6, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Jul 6, 2020

/cc @FiloSottile @katiehockman

@gopherbot
Copy link

Change https://golang.org/cl/241274 mentions this issue: crypto/x509/internal/macos: rename package to lowercase

@gopherbot
Copy link

Change https://golang.org/cl/241878 mentions this issue: crypto/x509/internal/macos: rename package name to lowercase

@golang golang locked and limited conversation to collaborators Jul 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
5 participants
@rsc @crawshaw @FiloSottile @dmitshur @gopherbot