cmd/vet: go vet should issue warning for nonsense json tags #40007
Labels
Analysis
Issues related to static analysis (vet, x/tools/go/analysis)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
|
package main
import (
"encoding/json"
"fmt"
)
type Foo struct {
B string `json:"bar:omitempty"`
}
type Foo2 struct {
B string `json:"bar,omitempty"`
}
func main() {
b := []byte(`{"bar:omitempty": "baz"}`)
var foo Foo
json.Unmarshal(b, &foo)
fmt.Println("with tag:", foo)
// with "fixed" tag
var foo2 Foo2
json.Unmarshal(b, &foo2)
fmt.Println("with fixed tag:", foo2)
}outputs with tag: {baz}
with fixed tag: {} |
|
That's why it should be a warning, not an error. This particular example is
almost certainly a typo that will lead to unexpected behavior.
…On Thu, Jul 2, 2020, 12:04 PM Sean Liao ***@***.***> wrote:
bar:omitempty is a valid tag though
package main
import (
"encoding/json"
"fmt"
)
type Foo struct {
B string `json:"bar:omitempty"`
}
type Foo2 struct {
B string `json:"bar,omitempty"`
}
func main() {
b := []byte(`{"bar:omitempty": "baz"}`)
var foo Foo
json.Unmarshal(b, &foo)
fmt.Println("with tag:", foo)
// with "fixed" tag
var foo2 Foo2
json.Unmarshal(b, &foo2)
fmt.Println("with fixed tag:", foo2)
}
outputs
with tag: {baz}
with fixed tag: {}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#40007 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAR5KLHG422R3WOQ6HM7Q7TRZSVZ5ANCNFSM4OO74LXQ>
.
|
cagedmantis
changed the title
cagedmantis
added
the
NeedsInvestigation
|
/cc @alandonovan |
adonovan
added
the
Analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
unsure, not tested
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
(no warnings)
What did you expect to see?
vet should warn about a possible typo: s/:omitempty/,omitempty/
What did you see instead?
no warning, just confusing app behavior
The text was updated successfully, but these errors were encountered: