Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: correctly resolve master in internal/proxy/test_helper.go #39985

Closed
julieqiu opened this issue Jul 1, 2020 · 4 comments
Closed

x/pkgsite: correctly resolve master in internal/proxy/test_helper.go #39985

julieqiu opened this issue Jul 1, 2020 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do. website
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Jul 1, 2020 •
edited

See https://github.com/golang/pkgsite/blob/master/internal/proxy/test_helper.go#L90
@gopherbot gopherbot added this to the Unreleased milestone Jul 1, 2020
@julieqiu julieqiu changed the title x/pkgsite: add support for tgm x/pkgsite: correctly resolve master in internal/proxy/test_helper.go Jul 1, 2020
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. help wanted Suggested Issues that may be good for new contributors looking for work to do. labels Jul 1, 2020
@gmelodie
Copy link

gmelodie commented Jul 3, 2020

I could give this a go if that's ok :)

@julieqiu
Copy link
Member Author

julieqiu commented Jul 3, 2020

Please do! :)

@julieqiu julieqiu removed the website label Sep 19, 2020
@Stexxe
Copy link

Stexxe commented Apr 14, 2021

@julieqiu could you please clarify how to reproduce this problem?

@julieqiu
Copy link
Member Author

@Stexxe this issue looks outdated, so I'm going to close this issue. Thanks for looking at it!

@golang golang locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do. website
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@julieqiu @Stexxe @gmelodie @gopherbot