Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: ErrBodyReadAfterClose text error message should be relevant for response as well #3997

Closed
gopherbot opened this issue Aug 23, 2012 · 4 comments
Milestone

Comments

@gopherbot
Copy link

by elazarl:

1. Create a new response
2. Write the response twice
3. The error you'll receive is, "http: invalid Read on closed request Body",
which is confusing, s/request/request or response/.

For example http://play.golang.org/p/tBwXSkWhMG

func main() {
    req, _ := http.NewRequest("GET",
        "http://google.com";, strings.NewReader(""))
    resp, _ := http.ReadResponse(
        bufio.NewReader(strings.NewReader(
        "HTTP/1.1 200 OK\r\n"+
        "Content-Type: text/plain\r\n"+
        "Content-Length: 1\r\n\r\na")), req)
    resp.Write(ioutil.Discard)
    fmt.Println(resp.Write(ioutil.Discard))
}

 [1] http://tip.golang.org/src/pkg/net/http/transfer.go#L528
@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

@gopherbot
Copy link
Author

Comment 2 by elazarl:

Can I do anything to help fixing it earlier? Will that help if I submit a (ridiculously
short) CL?

@rsc
Copy link
Contributor

rsc commented Sep 12, 2012

Comment 3:

Labels changed: added go1.1.

@rsc
Copy link
Contributor

rsc commented Dec 10, 2012

Comment 4:

This issue was closed by revision 4f3dd83.

Status changed to Fixed.

@rsc rsc added this to the Go1.1 milestone Apr 14, 2015
@rsc rsc removed the go1.1 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants