Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/internal/fetch/dochtml: remove template.HTML #39959

Closed
jba opened this issue Jun 30, 2020 · 1 comment
Closed

x/pkgsite/internal/fetch/dochtml: remove template.HTML #39959

jba opened this issue Jun 30, 2020 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
Unreleased

Comments

@jba
Copy link
Contributor

jba commented Jun 30, 2020

Use github.com/google/safehtml instead.
@jba jba added the pkgsite label Jun 30, 2020
@jba jba self-assigned this Jun 30, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 30, 2020
@gopherbot
Copy link

Change https://golang.org/cl/240515 mentions this issue: internal/fetch/dochtml/internal/render: use safehtml for CodeHTML

@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 4, 2020
gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 10, 2020
@jba
internal/fetch/dochtml/internal/render: use safehtml for CodeHTML
7fbc862 
codeHTML now returns safehtml.HTML instead of template.HTML

CodeHTML, which wraps codeHTML, must still return a template.HTML
until the main template uses safehtml/template. Otherwise
double-escaping will occur, where " is first replaced by "
and then by ".

Updates golang/go#39959.

Change-Id: I067bbfaad8292d1098c5438075631d3e166d0a2f
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/240515
Reviewed-by: Julie Qiu <julie@golang.org>
@jba jba closed this as completed Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @jba