Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: output caching stops working after some time passes #39947

Open
dmitshur opened this issue Jun 30, 2020 · 3 comments
Open

x/playground: output caching stops working after some time passes #39947

dmitshur opened this issue Jun 30, 2020 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 30, 2020 •
edited

It looks like #31889 has regressed. The same snippet can be used to observe it, re-running this program produces successful but different output each time:

https://play.golang.org/p/979rn6Bd7QN

I've noticed this when sharing a snippet (/cc @julieqiu) where a timeout due to a large dependency would happen occasionally. Usually, with output caching, getting it to succeed once makes it possible to share the snippet without risk of timeout because it no longer needs to execute again, but that wasn't the case.

/cc @toothrot @cagedmantis @andybons
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 30, 2020
@dmitshur dmitshur added this to the Backlog milestone Jun 30, 2020
@toothrot
Copy link
Contributor

This happens when our memcached instance is unhealthy. I've restarted it and it seems fine now. We should keep this issue open to improve this problem though.

@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 20, 2020 •
edited

It seems the memcached instance (memcached-play-golang per app.yaml) has become unhealthy again. I'll look into restarting it for now.

Edit: Restarting it fixed it.

@dmitshur dmitshur assigned dmitshur and unassigned dmitshur Jul 20, 2020
@dmitshur
Copy link
Contributor Author

As another data point, this has regressed and required another restart (22 days since last time).

@dmitshur dmitshur changed the title x/playground: output caching is not working x/playground: output caching stops working after some time passes Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@toothrot @dmitshur