Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: add metrics to teeproxy #39843

Closed
shaqque opened this issue Jun 25, 2020 · 2 comments
Closed

x/pkgsite: add metrics to teeproxy #39843

shaqque opened this issue Jun 25, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/godoc.org...

Comments

@shaqque
Copy link
Contributor

shaqque commented Jun 25, 2020

Add metrics to the teeproxy to measure latency and counts by response type.
@shaqque shaqque added NeedsFix The path to resolution is known, but the work has not been done. pkgsite labels Jun 25, 2020
@shaqque shaqque self-assigned this Jun 25, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 25, 2020
@gopherbot
Copy link

Change https://golang.org/cl/239818 mentions this issue: internal/teeproxy: add metrics for requests

@gopherbot
Copy link

Change https://golang.org/cl/241600 mentions this issue: internal/teeproxy: fix pkgGoDevLatency use in recordTeeProxyMetric

gopherbot pushed a commit to golang/pkgsite that referenced this issue Jul 9, 2020
@julieqiu
internal/teeproxy: fix pkgGoDevLatency use in recordTeeProxyMetric
a59b4ce 
recordTeeProxyMetric was using gddoLatency to calculate latency
for pkg.go.dev, which is now fixed.

For golang/go#39843

Change-Id: Id826d626b7409d75cf650df6b2191200f9a9dbe4
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/241600
Reviewed-by: Shaquille Que <shaquille@golang.org>
@golang golang locked and limited conversation to collaborators Jul 29, 2021
@rsc rsc unassigned shaqque Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/godoc.org-redirect
Development

No branches or pull requests
3 participants
@julieqiu @gopherbot @shaqque