Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

database/sql/sql.go: I wonder why 'defer' is not used to release mutex in the '(db *DB) putConn' function. #39814

Closed
Miss-you opened this issue Jun 24, 2020 · 1 comment
Closed

database/sql/sql.go: I wonder why 'defer' is not used to release mutex in the '(db *DB) putConn' function. #39814

Miss-you opened this issue Jun 24, 2020 · 1 comment
Labels
FrozenDueToAge

Comments

@Miss-you
Copy link

What version of Go are you using (go version)?

$ go version
master version

Does this issue reproduce with the latest release?

I don't know.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/yousa/Library/Caches/go-build"
GOENV="/Users/yousa/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/yousa/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.2_1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.2_1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/yousa/Documents/git/ingress/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qf/l8cy5cs9595967p86th95mk40000gn/T/go-build730450384=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Learn the code for the database/sql connection pool part.

What did you expect to see?

I wonder why 'defer' is not used to release mutex in the 'putConn' function.
image

What did you see instead?

image
@davecheney
Copy link
Contributor

Because defer does not run until the end of the function.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For asking questions, see:

@golang golang locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davecheney @Miss-you @gopherbot