Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/invoke/gocommand: tests are timing out #39802

Open
stamblerre opened this issue Jun 24, 2020 · 3 comments
Open

x/tools/internal/invoke/gocommand: tests are timing out #39802

stamblerre opened this issue Jun 24, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@stamblerre
Copy link
Contributor

Seems like a lot of tests are timing out on the builders (example failure). From the logs, my guess is that a serial go command invocation isn't returning in a reasonable amount of time, and it is blocking all the other go commands from running. A possible solution (or at least a first step for debugging) would be putting a timeout on a go command invocation.

/cc @heschik
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Jun 24, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 24, 2020
@stamblerre stamblerre changed the title x/tools/invoke/gocommand: tests are timing out x/tools/internal/invoke/gocommand: tests are timing out Jun 24, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 24, 2020
@heschi
Copy link
Contributor

heschi commented Jun 24, 2020

That log also includes a timeout from the gcimporter test, so I'm skeptical it's specific to gocommand. I'm suspicious of an issue with the Darwin builders. But adding a timeout certainly wouldn't hurt.

@stamblerre
Copy link
Contributor Author

Here's a log from a go/packages test: https://build.golang.org/log/ef9541b14411917139a452379e0f4d641dcd5540.
And an imports one: https://build.golang.org/log/ef9541b14411917139a452379e0f4d641dcd5540.

Definitely specific to Darwin though, I can't find a similar failure on other builders.

@stamblerre
Copy link
Contributor Author

/cc @dmitshur @cagedmantis @toothrot

This seems like an issue specific to the Darwin builder, so we were wondering if we could get your help investigating. I can't find any cases of it happening on any other builder.

@cagedmantis cagedmantis added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Builders x/build issues (builders, bots, dashboards) labels Jun 24, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.4.2, gopls/v0.5.0 Jun 26, 2020
@stamblerre stamblerre mentioned this issue Jul 8, 2020
Closed
@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jul 22, 2020
@seankhliao seankhliao added this to the Unreleased milestone Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @stamblerre @gopherbot @seankhliao @heschi