-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: EJI banner obscures widgets on page #39767
Comments
It seems you're right. Why is that distracting pale blue bar there then? It's just noticeable enough to look wrong. |
Not a web designer but I think is to mark the element your mouse is hovering. I agree it's a puzzling design choice, usually you do that by underling the words or by shading the whole button area with a different colour. I've never seen it done with a thin coloured line appearing on the top of the button. EDIT: I'm wrong, the red one is to highlight, the blue one in the screenshot is a different thing. |
The issue is that the blue bar is always there (only above "Discover Packages") and looks like an obstructed widget; I can understand the red bar that shows up with hover. Also, not a web designer, but did grow up in a graphic design family. This is very odd design. |
EDIT: actually I see it, on the "discover packages" item only. I think it's there to highlight it, and it's by design. Sorry for the confusion, but I think this is working as intended (and it's not changed by the banner, it's always like that). |
OK. I think it's bad design and probably should be changed; it's distracting and too subtle to actually draw attention to what it might be trying to draw attention to. This issue is not correct for that though and it seems like there's probably little interest in fixing it. If it will be entertained, I'll file an issue, otherwise I will just try to ignore it or continue to use godoc.org. |
@kortschak - feel free to file an issue. We can address this with our UX team for the next round of design changes. /cc @fflewddur @Joanne881107 |
What is the URL of the page with the issue?
https://pkg.go.dev/
What is your user agent?
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:77.0) Gecko/20100101 Firefox/77.0
Screenshot
Note the sliver of a button being obscured by the banner.
What did you do?
Browse to page.
What did you expect to see?
No obstructed page widgets; page moved down to make room for banner.
What did you see instead?
Image above.
The text was updated successfully, but these errors were encountered: