Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools: use GOMODCACHE where appropriate #39761

Closed
heschi opened this issue Jun 22, 2020 · 3 comments
Closed

x/tools: use GOMODCACHE where appropriate #39761

heschi opened this issue Jun 22, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Jun 22, 2020

Audit x/tools for assumptions that the module cache is in GOPATH[0]/pkg/mod and fix them to use GOMODCACHE when it's available. goimports and gopls are probably both affected.
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 22, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 22, 2020
@hyangah hyangah mentioned this issue Jun 22, 2020
Closed
@mvdan
Copy link
Member

mvdan commented Jun 23, 2020

Good point - I'll bring this up on the tools call tomorrow, as I'm sure some external tools would also be affected. We should fix these before the final 1.15 release is out.

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 23, 2020
@stamblerre
Copy link
Contributor

stamblerre commented Jun 24, 2020 •
edited

A quick grep indicates that the packages to fix are, as one would expect, internal/imports and internal/lsp. There are a few references to the module cache in go/packages/packagestest, but that hardcodes its own module cache.

@heschi heschi self-assigned this Jun 24, 2020
@gopherbot
Copy link

Change https://golang.org/cl/239754 mentions this issue: all: rework goimports environment, support GOMODCACHE

@golang golang locked and limited conversation to collaborators Jun 25, 2021
@rsc rsc unassigned heschi Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @mvdan @stamblerre @gopherbot @heschi