Skip to content

reflect: panic from malloc after MakeFunc function returns value that is also stored globally [1.14 backport] #39698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 18, 2020 · 3 comments
Closed

reflect: panic from malloc after MakeFunc function returns value that is also stored globally [1.14 backport] #39698

gopherbot opened this issue Jun 18, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.6

Comments

@gopherbot
Copy link
Contributor

@randall77 requested issue #39541 to be considered for backport to the next 1.14 minor release.

@gopherbot please open backport issues for 1.14 and 1.13.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 18, 2020
@gopherbot gopherbot mentioned this issue Jun 18, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.5 milestone Jun 18, 2020
@randall77
Copy link
Contributor

This issue is pretty rare, but causes random GC crashes when it does happen. Seems worth backporting.

@ianlancetaylor ianlancetaylor added the CherryPickApproved Used during the release process for point releases label Jun 19, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 19, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/238861 mentions this issue: [release-branch.go1.14] reflect: zero stack slots before writing to them with write barriers

gopherbot pushed a commit that referenced this issue Jul 11, 2020
@randall77 @dmitshur
[release-branch.go1.14] reflect: zero stack slots before writing to t…
d9bbff5 
…hem with write barriers

reflect.assignTo writes to the target using write barriers. Make sure
that the memory it is writing to is zeroed, so the write barrier does
not read pointers from uninitialized memory.

Fixes #39698

Change-Id: Ia64b2cacc193bffd0c1396bbce1dfb8182d4905b
Reviewed-on: https://go-review.googlesource.com/c/go/+/238760
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 3dec253)
Reviewed-on: https://go-review.googlesource.com/c/go/+/238861
@gopherbot
Copy link
Contributor Author

Closed by merging d9bbff5 to release-branch.go1.14.

@andybons andybons modified the milestones: Go1.14.5, Go1.14.6 Jul 14, 2020
@AriParkkila AriParkkila mentioned this issue Jan 26, 2021
Closed
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.6
Development

No branches or pull requests
4 participants
@andybons @ianlancetaylor @randall77 @gopherbot