Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp/regtest: flakes with "panic: unexpected reports from mod.Diagnostics" #39696

Closed
findleyr opened this issue Jun 18, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Jun 18, 2020

Seeing occasional flakes today with this error:

panic: unexpected reports from mod.Diagnostics

goroutine 27965 [running]:
golang.org/x/tools/internal/lsp.(*Server).diagnose(0xbeae2ff0, 0xed5616e0, 0xc6cd32f8, 0xed567b20, 0xc2b24480, 0xc2bab600, 0x0, 0x0)
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:78 +0xea0
golang.org/x/tools/internal/lsp.(*Server).diagnoseDetached(0xbeae2ff0, 0xed567b20, 0xc2b24480)
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/diagnostics.go:29 +0xaf
created by golang.org/x/tools/internal/lsp.(*Server).addFolders
	/workdir/gopath/src/golang.org/x/tools/internal/lsp/general.go:205 +0x5f0
exitcode=2FAIL	golang.org/x/tools/internal/lsp/regtest	40.191s

For example:

> greplogs -dashboard -l -md -E "FAIL.*internal/lsp/regtest" -E "unexpected reports from"
[2020-06-18T13:42:42-20370b0/android-386-emu](https://build.golang.org/log/59566c764f284063d2b7f747711a2107af5ad05f)
[2020-06-18T11:25:59-5fddd30/freebsd-amd64-race](https://build.golang.org/log/3d184cf64ed3ab6b3eb01e4de32d580b8d505511)
[2020-06-18T02:37:23-47c907e/freebsd-amd64-11_2](https://build.golang.org/log/d201036f5215312b8b6914bee72fa69f267e9fce)

Based on the timing and the nature of the panic, I suspect https://golang.org/cl/237517. CC @stamblerre @heschik

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone Jun 18, 2020
@gopherbot
Copy link

Change https://golang.org/cl/239040 mentions this issue: internal/lsp: fix panic in computing diagnostics for module

@golang golang locked and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants