Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: s390x floating point <-> integer conversions clobbering the condition code [1.13 backport] #39689

Closed
gopherbot opened this issue Jun 18, 2020 · 3 comments
Closed

cmd/compile: s390x floating point <-> integer conversions clobbering the condition code [1.13 backport] #39689

gopherbot opened this issue Jun 18, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.16

Comments

@gopherbot
Copy link

@mundaym requested issue #39651 to be considered for backport to the next 1.13 minor release.

@gopherbot please consider this for a backport

This is a bug that affects the control flow of a program running on s390x and therefore can result in it behaving incorrectly. The fix is simple and safe and only affects s390x.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 18, 2020
@gopherbot gopherbot mentioned this issue Jun 18, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.13 milestone Jun 18, 2020
@dmitshur dmitshur mentioned this issue Jul 10, 2020
Closed
@dmitshur
Copy link
Contributor

Approved for 1.14 (#39690) and 1.13 (this issue) as it's a serious problem without a workaround.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jul 10, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/242238 mentions this issue: [release-branch.go1.13] cmd/compile: mark s390x int <-> float conversions as clobbering flags

@andybons andybons modified the milestones: Go1.13.13, Go1.13.14, Go1.13.15 Jul 14, 2020
@toothrot toothrot modified the milestones: Go1.13.15, Go1.13.16 Aug 6, 2020
@dmitshur
Copy link
Contributor

Go 1.13 is no longer supported per release policy, so this backport issue is no longer needed and can be closed.

@golang golang locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.16
Development

No branches or pull requests
4 participants
@toothrot @andybons @dmitshur @gopherbot