Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: compare modules with different paths #39666

Closed
jayconrod opened this issue Jun 17, 2020 · 3 comments
Closed

x/exp/cmd/gorelease: compare modules with different paths #39666

jayconrod opened this issue Jun 17, 2020 · 3 comments
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gorelease

Comments

@jayconrod
Copy link
Contributor

jayconrod commented Jun 17, 2020 •
edited

gorelease should be able to compare packages in two modules with different module paths. This is useful for 1) comparing across major versions, especially for the first release on a new major version, and 2) comparing an original module and a fork.

This could be implemented by expanding the -base flag to accept a module path and a version.

gorelease -base=example.com/m@v1.9.9 -version=v2.0.0
@jayconrod jayconrod added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. modules Tools This label describes issues relating to any tools in the x/tools repository. labels Jun 17, 2020
@jayconrod jayconrod added this to the Unreleased milestone Jun 17, 2020
@gopherbot
Copy link

Change https://golang.org/cl/238838 mentions this issue: cmd/gorelease: extract loading functions out of makeReleaseReport

@gopherbot
Copy link

Change https://golang.org/cl/238839 mentions this issue: cmd/gorelease: support comparison of modules with different paths

@jayconrod jayconrod mentioned this issue Aug 19, 2020
Closed
gopherbot pushed a commit to golang/exp that referenced this issue Aug 21, 2020
cmd/gorelease: extract loading functions out of makeReleaseReport
94841d0 
This is a refactoring CL: there should be no visible change in behavior.

There are several feature requests related to loading the base and
release versions from different places or with different module
paths. This CL enables that work by extracting two functions out of
makeReleaseReport.

loadLocalModule loads the release version from a local directory.

loadDownloadedModule downloads the base version and loads it from the
module cache.

In the future, base and release may not necessarily be remote and local.

For golang/go#39666

Change-Id: I37955caacf02479b7a3eaf03782f140a42f3a87e
Reviewed-on: https://go-review.googlesource.com/c/exp/+/238838
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@jayconrod jayconrod modified the milestones: Unreleased, gorelease Oct 14, 2020
gopherbot pushed a commit to golang/exp that referenced this issue Dec 10, 2020
cmd/gorelease: support comparison of modules with different paths
a20c86d 
For golang/go#39666

Change-Id: I7e69ef14a3f6b3996ceea2a70ec4ce1e33f912c6
Reviewed-on: https://go-review.googlesource.com/c/exp/+/238839
Trust: Jay Conrod <jayconrod@google.com>
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/277116 mentions this issue: cmd/gorelease: support comparing replacement modules

@golang golang locked and limited conversation to collaborators Dec 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gorelease
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot