Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: fix links that should be versioned #39630

Closed
3 of 4 tasks
julieqiu opened this issue Jun 17, 2020 · 4 comments
Closed
3 of 4 tasks

x/pkgsite: fix links that should be versioned #39630

julieqiu opened this issue Jun 17, 2020 · 4 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
pkgsite/unplanned

Comments

@julieqiu
Copy link
Member

julieqiu commented Jun 17, 2020 •
edited

We should version the following links on the details pages with the semantic version at the time of request:

  • module
  • breadcrumbs
  • packages on Subdirectories tab
  • package source link

Related: #39621
@gopherbot gopherbot added this to the Unreleased milestone Jun 17, 2020
@julieqiu julieqiu added pkgsite NeedsFix The path to resolution is known, but the work has not been done. help wanted Suggested Issues that may be good for new contributors looking for work to do. labels Jun 17, 2020
@julieqiu julieqiu changed the title x/pkgsite: clean up versioned / unversioned links x/pkgsite: fix which links should be versioned / unversioned Jun 23, 2020
@julieqiu julieqiu changed the title x/pkgsite: fix which links should be versioned / unversioned x/pkgsite: fix links that should be versioned Jun 23, 2020
@gmelodie
Copy link

gmelodie commented Jul 3, 2020

I could try my hand at this if no one else has already started :)

@julieqiu
Copy link
Member Author

julieqiu commented Jul 3, 2020

Please do! :)

@mvdan mvdan mentioned this issue Sep 10, 2020
Open
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@Hallicopter
Copy link

Hi @julieqiu, could you elaborate on the issue a bit? I would like to help since the issue has become inactive for a while now.

@julieqiu
Copy link
Member Author

@Hallicopter this issue looks to be out of date - closing this issue. Thanks for looking into it!

@golang golang locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
4 participants
@julieqiu @gmelodie @gopherbot @Hallicopter