Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux-386-longtest builder because it tries to use an older version of dlv which only supports linux/amd64 [1.14 backport] #39562

Closed
gopherbot opened this issue Jun 12, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@dmitshur requested issue #39309 to be considered for backport to the next 1.14 minor release.

@gopherbot Please consider for backport, this is a test skip for a test that is expected not to pass due to insufficient environment preconditions. This is to uncover additional test failures on the linux-386-longtest builder that would otherwise be masked.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 12, 2020
@gopherbot gopherbot added this to the Go1.14.5 milestone Jun 12, 2020
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 12, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/237619 mentions this issue: [release-branch.go1.14] cmd/compile/internal/ssa: skip TestNexting with old Delve on linux/386

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Jun 12, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2020
@toothrot
Copy link
Contributor

Approving for backport. This test could be masking other issues.

@gopherbot
Copy link
Author

Closed by merging 73f86d2 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Jun 12, 2020
…th old Delve on linux/386

Support for linux/386 was added to Delve in version 1.4.1, but the
version of Delve currently installed on the linux-386-longtest
builder is 1.2.0. That isn't new enough, which causes the test
to fail. Skip it on that builder until it can be made to work.

The only reason it used to pass on the linux-386-longtest builder
before is because that builder was misconfigured to run tests for
linux/amd64. This was resolved in CL 234520.

Also improve internal documentation and the text of skip reasons.

For #39309.
Fixes #39562.

Change-Id: I395cb1f076e59dd3a3feb53e1dcdce5101e9a0f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/237619
Reviewed-by: David Chase <drchase@google.com>
@andybons andybons modified the milestones: Go1.14.5, Go1.14.6 Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants