x/crypto/ed25519: a correction and a suggestion for adding comments for crypto/ed25519 #39554
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Firstly, a correction should be in edwards25519.go:725. There's a mistake in the comment of "FeSub(&u, &u, &p.Z) // y = y^2-1". According to ed's paper, it should have been u = y^2-1.
Secondly, in edwards25519.go:562 " func fePow22523(out, z *FieldElement)" , we can't know what it will do just by the name of the function. Although it's a internal func, I still suggest adding comments for it, like this:
The text was updated successfully, but these errors were encountered: