Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/releasebot: add a check for beta1 release blockers #39345

Closed
dmitshur opened this issue Jun 1, 2020 · 3 comments
Closed

x/build/cmd/releasebot: add a check for beta1 release blockers #39345

dmitshur opened this issue Jun 1, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 1, 2020

We can add a check to have releasebot report an error and refuse to proceed with a beta1 release, when there is an issue deemed to be a release blocker for the given milestone, and is not deemed to be okay to fix after beta1.

This reduces the risk of a release coordinator (a human) accidentally performing a release when there is an issue that should block the release.

I have a fix for this.

/cc @andybons @toothrot @cagedmantis

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Jun 1, 2020
@dmitshur dmitshur added this to the Unreleased milestone Jun 1, 2020
@dmitshur dmitshur self-assigned this Jun 1, 2020
@gopherbot
Copy link

Change https://golang.org/cl/235937 mentions this issue: cmd/releasebot: factor out version checks from doRelease

@gopherbot
Copy link

Change https://golang.org/cl/235778 mentions this issue: cmd/releasebot: add check for beta1 release blockers

gopherbot pushed a commit to golang/build that referenced this issue Jun 2, 2020
Previously, the GitHub milestones were searched for first,
and version validation was done second. This refactor moves
the error checks to happen earlier, in main. That gives
confidence the version has passed checks before starting
to look for a milestone.

Improve documentation of the Milestone and NextMilestone fields,
and always populate the current Milestone field for all releases.

This helps the upcoming change in CL 235778, where a check for
release blocker issues is being added for beta1 releases.

For golang/go#39345.

Change-Id: Id1cda24a0e140e1e2d02e47b78f353157d4c743a
Reviewed-on: https://go-review.googlesource.com/c/build/+/235937
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/236259 mentions this issue: cmd/releasebot: trim pre-release suffix in getMilestone

gopherbot pushed a commit to golang/build that referenced this issue Jun 3, 2020
Pre-release versions like go1.15beta1 use the same milestone
as the release version go1.15, a milestone named "Go1.15".
Handle this in getMilestone by trimming the pre-release suffix.

Also simplify ForeachMilestone error handling. The only error
ForeachMilestone returns is that of fn, which isn't interesting.

For golang/go#39345.

Change-Id: I19ddca7736d97791cc6d7d6986fd39c61db437e2
Reviewed-on: https://go-review.googlesource.com/c/build/+/236259
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants