Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: license not detected on pkg.go.dev #39318

Closed
josh-newman opened this issue May 30, 2020 · 8 comments
Closed

x/pkgsite: license not detected on pkg.go.dev #39318

josh-newman opened this issue May 30, 2020 · 8 comments
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Unreleased

Comments

@josh-newman
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/apache/arrow/go/arrow?tab=overview

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36

Screenshot

http://web.archive.org/web/20200530011330/https://pkg.go.dev/github.com/apache/arrow/go/arrow?tab=overview

What did you do?

Just visited the page.

What did you expect to see?

Documentation for package github.com/apache/arrow/go/arrow.

What did you see instead?

A message saying documentation could not be shown because of license restrictions. The repository, github.com/apache/arrow, has the Apache 2.0 license at its root, which the pkg.go.dev license policy accepts. godoc.org shows documentation for this package, too.
@gopherbot gopherbot added this to the Unreleased milestone May 30, 2020
@josh-newman
Copy link
Author

I just discovered #37437, which seems like the same issue. That reporter worked around it before it was fixed. In this case, github.com/apache/arrow is not my code, so I'd still be interested in seeing pkg.go.dev recognize the existing license.

@julieqiu
Copy link
Member

julieqiu commented Jun 4, 2020

/cc @jba

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 4, 2020
@jba
Copy link
Contributor

jba commented Jun 4, 2020

The problem here is that pkg.go.dev only sees the tree rooted at the module (location of the go.mod file). What we actually consume is a zip file of that tree, handed to us by https://proxy.golang.org. We don't have the repo (although, as you can tell from the site, we do display a link to it). So the license file must appear at the repo root.

I filed apache/arrow#7351.

@jba jba self-assigned this Jun 4, 2020
@jba jba removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 4, 2020
@josh-newman
Copy link
Author

josh-newman commented Jun 5, 2020 •
edited

Thanks for looking into this, @jba. I'm seeing now that the arrow module page fetched commit apache/arrow@6a1cdbc which is after the license copy in apache/arrow#7355, but it still says there's a license error. Does the license file need to move to go/arrow?

@josh-newman josh-newman reopened this Jun 5, 2020
@josh-newman
Copy link
Author

(Sorry, I closed this accidentally.)

@josh-newman josh-newman mentioned this issue Jun 6, 2020
Closed
@jba
Copy link
Contributor

jba commented Jun 8, 2020

I commented on the PR (but don't have permission to reopen the Jira issue, AFAICT).

@julieqiu julieqiu added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Jun 8, 2020
@julieqiu julieqiu changed the title go.dev: license not detected on pkg.go.dev x/pkgsite: license not detected on pkg.go.dev Jun 15, 2020
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@jba
Copy link
Contributor

jba commented Jul 29, 2020

gopherbot is right for the wrong reasons: this problem is fixed as of the latest version: https://pkg.go.dev/github.com/apache/arrow/go/arrow.

@golang golang locked and limited conversation to collaborators Jul 29, 2021
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@josh-newman @julieqiu @gopherbot @jba