Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/relui: a possibility of an unexpected backport CL being merged to release branch between -mode=prepare and -mode=release #39317

Closed
dmitshur opened this issue May 30, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 30, 2020

Currently, the release process involves running releasebot first in prepare mode, then again in release mode.

For release types other than beta, a CL that updates the VERSION file is created in prepare mode. It is also tested (soon, including longtest builders, see #29252). After that CL is submitted to the release branch, the release mode takes the latest commit on the release branch and produces a release, skipping all testing (because thorough testing was done in prepare mode).

There is a possibility of a change being submitted to the release branch between the time the CL updating the VERSION file is created and tested in prepare mode, and the release mode picking it up. That would mean the CL that landed would bypass all testing done in prepare mode.

This issue is low priority for two reasons:

  1. The chance of this happening is low because only a small set of release managers have access to submit changes to release branches, and we are generally aware when a release is happening and manually avoid touching the release branch.

  2. Additionally, changes to release branches undergo testing (soon, including longtest builders, see x/build/cmd/coordinator: include -longtest and -race builders for trybots on release branches #37827), so there isn't a risk of introducing a problem that would be caught by testing.

However, it would still be unintentional if it happened, and it might require release notes to be updated. This is the tracking issue to investigate and implement a way to remove this small possibility of a human mistake. It was split off from #36182.

/cc @toothrot @cagedmantis @andybons

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 30, 2020
@dmitshur dmitshur added this to the Backlog milestone May 30, 2020
@gopherbot
Copy link

Change https://go.dev/cl/411197 mentions this issue: internal/relui: check for stray commits

@dmitshur dmitshur changed the title x/build/cmd/releasebot: a possibility of an unexpected backport CL being merged to release branch between -mode=prepare and -mode=release x/build/cmd/relui: a possibility of an unexpected backport CL being merged to release branch between -mode=prepare and -mode=release Jun 8, 2022
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 8, 2022
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Jun 8, 2022
@cagedmantis cagedmantis added this to Done in Go Release Team Jun 21, 2022
@rsc rsc unassigned heschi Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants