Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux-386-longtest builder because it tries to use an older version of dlv which only supports linux/amd64 #39309

Closed
dmitshur opened this issue May 28, 2020 · 6 comments
Closed

cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux-386-longtest builder because it tries to use an older version of dlv which only supports linux/amd64 #39309

dmitshur opened this issue May 28, 2020 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.

Comments

@dmitshur
Copy link
Contributor

(Factoring out this specific problem from #37050.)

The TestNexting/dlv-dbg-hist test is failing on linux-386-longtest builder on release-branch.go1.14 and release-branch.go1.13:

See #37050 (comment) and other comments for more details.

This is determined to be a problem of the test, because delve doesn't support linux/386 (according to #37050 (comment)), yet it's attempted to be used by the test.

To make progress, we need to decide how best to improve this test so it no longer fails.

(Note the test is flaky on linux/amd64 for unrelated reasons, and skipped on tip; that is tracked in issue #37404.)

/cc @dr2chase @cagedmantis @toothrot @andybons
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 28, 2020
@dmitshur dmitshur mentioned this issue May 28, 2020
Closed
@dmitshur
Copy link
Contributor Author

dmitshur commented Jun 12, 2020 •
edited

This is determined to be a problem of the test, because delve doesn't support linux/386 (according to #37050 (comment)), yet it's attempted to be used by the test.

I was looking up a reference for that, and learned that support for linux/386 was added to delve as recently as a few months ago in Delve 1.4.1 (see CHANGELOG and go-delve/delve#1884). The version of Delve currently available in the linux-386-longtest builder is 1.2.0.

This test is completely skipped on 1.15 branch because it's flaky (see #37404, /cc @bcmills). As a result, it doesn't seem worth investing a lot in trying to fix this test on 386 in its current state.

For now, I'll write a comment saying that the version of delve installed on linux-386-longtest doesn't yet support linux/386 and skip for that reason. It seems reasonable to me that if we want to add support for TestNexting using delve on linux/386, we can consider doing that in a future version of Go (e.g., 1.15 or later).

@dmitshur dmitshur self-assigned this Jun 12, 2020
@gopherbot
Copy link

Change https://golang.org/cl/237603 mentions this issue: cmd/compile/internal/ssa: skip TestNexting with old delve on linux/386

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 12, 2020
@dmitshur dmitshur changed the title cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux/386 because it tries to use dlv, which only supports linux/amd64 cmd/compile/internal/ssa: TestNexting/dlv-dbg-hist failing on linux-386-longtest builder because it tries to use an older version of dlv which only supports linux/amd64 Jun 12, 2020
@dmitshur dmitshur mentioned this issue Jun 12, 2020
Closed
@dmitshur
Copy link
Contributor Author

@gopherbot Please consider for backport, this is a test skip for a test that is expected not to pass due to insufficient environment preconditions. This is to uncover additional test failures on the linux-386-longtest builder that would otherwise be masked.

@gopherbot gopherbot mentioned this issue Jun 12, 2020
Closed
@gopherbot
Copy link

Backport issue(s) opened: #39561 (for 1.13), #39562 (for 1.14).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Jun 12, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/237619 mentions this issue: [release-branch.go1.14] cmd/compile/internal/ssa: skip TestNexting with old Delve on linux/386

@gopherbot
Copy link

Change https://golang.org/cl/237617 mentions this issue: [release-branch.go1.13] cmd/compile/internal/ssa: skip TestNexting with old Delve on linux/386

gopherbot pushed a commit that referenced this issue Jun 12, 2020
@dmitshur
[release-branch.go1.13] cmd/compile/internal/ssa: skip TestNexting wi…
034ed80 
…th old Delve on linux/386

Support for linux/386 was added to Delve in version 1.4.1, but the
version of Delve currently installed on the linux-386-longtest
builder is 1.2.0. That isn't new enough, which causes the test
to fail. Skip it on that builder until it can be made to work.

The only reason it used to pass on the linux-386-longtest builder
before is because that builder was misconfigured to run tests for
linux/amd64. This was resolved in CL 234520.

Also improve internal documentation and the text of skip reasons.

For #39309.
Fixes #39561.

Change-Id: I395cb1f076e59dd3a3feb53e1dcdce5101e9a0f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/237617
Reviewed-by: David Chase <drchase@google.com>
gopherbot pushed a commit that referenced this issue Jun 12, 2020
@dmitshur
[release-branch.go1.14] cmd/compile/internal/ssa: skip TestNexting wi…
73f86d2 
…th old Delve on linux/386

Support for linux/386 was added to Delve in version 1.4.1, but the
version of Delve currently installed on the linux-386-longtest
builder is 1.2.0. That isn't new enough, which causes the test
to fail. Skip it on that builder until it can be made to work.

The only reason it used to pass on the linux-386-longtest builder
before is because that builder was misconfigured to run tests for
linux/amd64. This was resolved in CL 234520.

Also improve internal documentation and the text of skip reasons.

For #39309.
Fixes #39562.

Change-Id: I395cb1f076e59dd3a3feb53e1dcdce5101e9a0f5
Reviewed-on: https://go-review.googlesource.com/c/go/+/237619
Reviewed-by: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot