Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: repeats completion prefix for identifiers in comments #39262

Closed
heschi opened this issue May 26, 2020 · 4 comments
Closed

x/tools/gopls: repeats completion prefix for identifiers in comments #39262

heschi opened this issue May 26, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@heschi
Copy link
Contributor

heschi commented May 26, 2020

With gopls at tip, completing in comments doesn't overwrite the completion prefix. For example, in:

package main

// Foo<>
func FooDoesAThing() {}

you get a completion that yields

package main

// FooFooDoesAThing
func FooDoesAThing() {}

cc @clintjedwards
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 26, 2020
@gopherbot gopherbot added this to the Unreleased milestone May 26, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 May 26, 2020
@clintjedwards
Copy link

@heschik looking at it

@stamblerre stamblerre removed this from the gopls/v0.5.0 milestone Jun 24, 2020
@stamblerre stamblerre mentioned this issue Jun 24, 2020
Open
@geekjam geekjam mentioned this issue Jul 1, 2020
Closed
@clintjedwards
Copy link

Apologies, I've been super busy with other projects. Taking a look at this, this week.

@stamblerre stamblerre added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 23, 2020
@stamblerre stamblerre added this to the gopls/v1.0.0 milestone Jul 23, 2020
@clintjedwards
Copy link

clintjedwards commented Jul 26, 2020 •
edited

I've poked and prodded at this over the last week and I've mostly been stuck trying to parse the logic around how the prefixes are handled for other instances of this issue. Unfortunately, I'm no closer to solving it and I'm going through a move and job switch at the moment so I can't dedicate any time in the near term.

Throwing back to the pool for someone else to hopefully pick up. Apologies!

@dandua98 dandua98 self-assigned this Jul 29, 2020
@gopherbot
Copy link

Change https://golang.org/cl/246237 mentions this issue: internal/lsp/source: Fix completion in comments not overwriting completion prefix

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v.0.4.5 Aug 5, 2020
@fannheyward fannheyward mentioned this issue Aug 6, 2020
Closed
@hyangah hyangah mentioned this issue Sep 3, 2020
Closed
@golang golang locked and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. help wanted NeedsFix The path to resolution is known, but the work has not been done. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

No branches or pull requests
5 participants
@clintjedwards @stamblerre @gopherbot @heschi @dandua98