Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: /<path> should show the contents for the latest version of the containing module #39244

Closed
hhrutter opened this issue May 25, 2020 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite

Comments

@hhrutter
Copy link

What is the URL of the page with the issue?

https://godoc.org/github.com/pdfcpu/pdfcpu asks to switch to go.dev

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36

What did you do?

Go to pdfcpu and click on the godoc badge.
Then accept to switch to go.dev

What did you expect to see?

The go.dev page showing the latest release (v0.3.3) of pdfcpu

What did you see instead?

It shows the old release v0.1.11 with a blue badge latest which is false.

@gopherbot gopherbot added this to the Unreleased milestone May 25, 2020
@mdlayher mdlayher changed the title go.dev: go.dev: outdated release displayed as latest May 25, 2020
@findleyr
Copy link
Contributor

The reason this gets the 'latest' badge is because the redirect takes you to the package page for the package github.com/pdfcpu/pdfcpu, which I'm guessing last existed at v0.1.11 at that specific path. Pkg.go.dev does in fact have v0.3.3 of the module: https://pkg.go.dev/mod/github.com/pdfcpu/pdfcpu?tab=versions

So there are two problems here, AFAICT:

  1. The UX of viewing the latest version of a package that has been moved/removed is confusing. This is already being worked on in x/pkgsite: flag packages that are no longer present in the latest version of the containing module #37631
  2. The pkg.go.dev redirector doesn't take you to the correct page in this case. When you're viewing a directory (not a package) on godoc.org, it should take you to that subdirectory in the latest version of the module. I'm not sure if that issue has yet been raised.

CC @julieqiu @jba

@findleyr findleyr changed the title go.dev: outdated release displayed as latest pkg.go.dev: godoc.org points to outdated package version when package has been moved May 25, 2020
@julieqiu
Copy link
Member

Thanks for the feedback, @hhrutter! We're working fixes for both the points that @findleyr raised. This issue is specially related to the second point - the latest version of a given path should show what exists in the latest version of the module that it corresponds to.

@julieqiu julieqiu added the NeedsFix The path to resolution is known, but the work has not been done. label May 25, 2020
@julieqiu julieqiu changed the title pkg.go.dev: godoc.org points to outdated package version when package has been moved pkg.go.dev: /<path> should show the contents for the latest version of the containing module May 25, 2020
@hhrutter
Copy link
Author

Thanks for looking into this!

@jba jba self-assigned this May 26, 2020
@julieqiu julieqiu changed the title pkg.go.dev: /<path> should show the contents for the latest version of the containing module x/pkgsite: /<path> should show the contents for the latest version of the containing module Jun 15, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu
Copy link
Member

Fixed.

@golang golang locked and limited conversation to collaborators Oct 29, 2021
@rsc rsc unassigned jba Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants