Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: TestTransportPingWhenReading fails on Plan 9 #39233

Closed
millerresearch opened this issue May 24, 2020 · 2 comments
Closed

x/net/http2: TestTransportPingWhenReading fails on Plan 9 #39233

millerresearch opened this issue May 24, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@millerresearch
Copy link
Contributor

What version of Go are you using (go version)?

Current master on sub-repo builders.

What operating system and processor architecture are you using (go env)?

Plan 9, affects arm, 386 and amd64.

I think this is a new test, introduced in CL198040

Example logs for each GOARCH:
https://build.golang.org/log/aa9acd550974f473c6fa49e100c751e2d64be3d0
https://build.golang.org/log/ab04d68c8dc68e4192029ce39c1429906413efed
https://build.golang.org/log/8b4eb0a7cda60a1af29c2d2b03396aa51aaa2187
@tklauser tklauser added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 25, 2020
@millerresearch
Copy link
Contributor Author

The new test was using (*TCPConn).CloseWrite which doesn't work on Plan 9, because the Plan 9 kernel's tcp/ip implementation doesn't support half-close. See #17906. I'll send a CL with the usual workaround (call (*TCPConn).Close as well).

@gopherbot
Copy link

Change https://golang.org/cl/235217 mentions this issue: x/net/http2: don't rely on TCP CloseWrite in tests on Plan 9

@dmitshur dmitshur mentioned this issue Jul 15, 2020
Closed
@golang golang locked and limited conversation to collaborators Jun 2, 2021
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@0intro
x/net/http2: don't rely on TCP CloseWrite in tests on Plan 9
8405c95 
In TestTransportPingWhenReading, a TCP half-close was being used,
which isn't supported in the Plan 9 kernel. The workaround is to
call (*TCPConn).Close when running on Plan 9.

See golang/go#17906

Fixes golang/go#39233

Change-Id: Ifb2934621fb53d76a3b161b239c438c13f8c508e
Reviewed-on: https://go-review.googlesource.com/c/net/+/235217
Reviewed-by: David du Colombier <0intro@gmail.com>
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tklauser @gopherbot @millerresearch