Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: support an x/tools SlowBot for platforms other than linux-amd64 #39201

Closed
bcmills opened this issue May 21, 2020 · 3 comments
Closed

x/build: support an x/tools SlowBot for platforms other than linux-amd64 #39201

bcmills opened this issue May 21, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release Team
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented May 21, 2020

I suspect that pending CL 234879 may break some x/tools tests on Windows specifically, but it's a huge pain to set up a gomote instance capable of testing x/tools in a realistic configuration (see #32430), and I don't keep a Windows development workstation running otherwise.

The current SlowBot support allows me to add an x/tools run for linux-amd64 by adding a comment with:

TRY=x/tools

And it currently allows me to add a Windows long-test run by adding a comment with:

TRY=windows-amd64-longtest

Unfortunately, it does not seem to support the combination of the two: a run for x/tools in the windows-amd64-longtest configuration. It would be very convenient for me if it did.

CC @golang/osp-team @stamblerre @ianthehat
@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels May 21, 2020
@bcmills bcmills added this to the Backlog milestone May 21, 2020
@dmitshur
Copy link
Contributor

SlowBots are intended to allow custom and slow testing, so I believe this is in scope. It's a matter of figuring out a syntax for it and implementing the feature.

As a starting point, I'll suggest the following syntax:

# picks default linux-amd64 builder to test x/tools
TRY=x/tools

# tests x/tools with windows-amd64-longtest builder
TRY=x/tools@windows-amd64-longtest

@gopherbot
Copy link

Change https://golang.org/cl/342712 mentions this issue: cmd/coordinator: support specifying a builder for x-repo trybots

@toothrot toothrot added this to In Progress in Go Release Team Aug 24, 2021
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 31, 2021
gopherbot pushed a commit to golang/build that referenced this issue Sep 2, 2021
@findleyr
cmd/coordinator: support specifying a builder for x-repo slowbots
dc54d45 
Add support for the syntax `x/repo@builder`, as suggested in #39201.

For golang/go#39201

Change-Id: Iac49169f12b90cbdfea626fcb4f5408358639760
Reviewed-on: https://go-review.googlesource.com/c/build/+/342712
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@findleyr
Copy link
Contributor

findleyr commented Sep 2, 2021

This is now deployed to the coordinator and seems to work, so closing. Please re-open if any issues.

@findleyr findleyr closed this as completed Sep 2, 2021
Go Release Team automation moved this from In Progress to Done Sep 2, 2021
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Go Release Team
Done
Milestone
Backlog
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @gopherbot @findleyr