Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: set allowed changes with -compatibility flag #39191

Open
jayconrod opened this issue May 21, 2020 · 0 comments
Open

x/exp/cmd/gorelease: set allowed changes with -compatibility flag #39191

jayconrod opened this issue May 21, 2020 · 0 comments
Labels
FeatureRequest modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gorelease

Comments

@jayconrod
Copy link
Contributor

Currently, gorelease determines whether compatible and incompatible API changes are allowed based on the module base version and release version. It follows semver guidelines, for example, allowing incompatible changes at base major version v0.

Users may want to apply different (usually stricter) compatibility guidelines. For example, a module may want to forbid incompatible API changes between minor versions at v0, even though semver allows them.

gorelease should accept a -compatibility flag that allows users to set the compatibility level explicitly. For example:

gorelease -base=v0.10.0 -release=v0.10.1 -compatibility=patch
gorelease -base=v0.10.0 -release=v0.11.0 -compatibility=minor
gorelease -base=v0.10.0 -release=v0.15.0 -compatibility=major

cc @liggitt
@jayconrod jayconrod added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest modules Tools This label describes issues relating to any tools in the x/tools repository. labels May 21, 2020
@jayconrod jayconrod added this to the Unreleased milestone May 21, 2020
@jayconrod jayconrod modified the milestones: Unreleased, gorelease May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest modules NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gorelease
Development

No branches or pull requests
1 participant
@jayconrod