Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get reports "path does not match GOPRIVATE/GONOPROXY" #39180

Closed
heschi opened this issue May 20, 2020 · 4 comments
Closed

cmd/go: go get reports "path does not match GOPRIVATE/GONOPROXY" #39180

heschi opened this issue May 20, 2020 · 4 comments
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@heschi
Copy link
Contributor

heschi commented May 20, 2020

What version of Go are you using (go version)?

$ go version
go version devel +f7f9c8f2fb Wed May 20 15:57:15 2020 +0000 linux/amd64

Does this issue reproduce with the latest release?

No.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
...
GONOPROXY="github.com/heschik"
GONOSUMDB="github.com/heschik"
GOPRIVATE="github.com/heschik"
GOPROXY="https://proxy.golang.org,direct"
...

What did you do?

/tmp $ GO111MODULE=on ~/go/bin/go get golang.org/x/tools@master

What did you expect to see?

go: golang.org/x/tools master => v0.0.0-20200519205726-57a9e4404bf7

What did you see instead?

go get golang.org/x/tools@master: path does not match GOPRIVATE/GONOPROXY

@heschi heschi added this to the Go1.15 milestone May 20, 2020
@jayconrod jayconrod added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels May 20, 2020
@jayconrod
Copy link
Contributor

This is likely a regression due to CL 226460.

@gopherbot
Copy link

Change https://golang.org/cl/234687 mentions this issue: cmd/go: rank errUseProxy lower when handling proxy errors

@jayconrod jayconrod changed the title cmd/go: strange error message downloading golang.org/x/tools@master cmd/go: go get reports "path does not match GOPRIVATE/GONOPROXY" May 20, 2020
@gopherbot
Copy link

Change https://golang.org/cl/234857 mentions this issue: cmd/go: report error for empty GOPROXY list

1 similar comment
@gopherbot
Copy link

Change https://golang.org/cl/234857 mentions this issue: cmd/go: report error for empty GOPROXY list

gopherbot pushed a commit that referenced this issue May 26, 2020
If GOPROXY is "", we set it to the default value,
"https://proxy.golang.org,direct". However, if GOPROXY is a non-empty
string that doesn't contain any URLs or keywords, we treat it as
either "off" or "noproxy", which can lead to some strange errors.

This change reports an error for this kind of GOPROXY value.

For #39180

Change-Id: If2e6e39d6f74c708e5ec8f90e9d4880e0e91894f
Reviewed-on: https://go-review.googlesource.com/c/go/+/234857
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
@golang golang locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go modules NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants