database/sql: collect database metric information using dbstats #39161
Labels
Comments
|
having unprotected pointers to mutable data races possible |
|
As mentioned by @seankhliao, I'm going to close this issue since this is working as expected. Please feel free to follow up if this was done in error. |
|
@cagedmantis Thanks for reply. If i want to collect DB metrics every second, is it ok to call db.Stats() every second? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What version of Go are you using (
go version)?Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (
go env)?go envOutputWhat did you do?
Purpose: I want to get database metric information in go application.
So here is a source code.
db, err := sql.Open("postgres", connectionInfo)
dbstat := db.Stats()
db.SetMaxOpenConns(20)
fmt.Println(dbstat.MaxOpenConnections)
What did you expect to see?
I expected the printed number is 20
What did you see instead?
The result of the code was 0 (default value)
When i took a look at dbstat struct, I realized that all the type of field assigned int or string, not pointer.
Is there any problem that change fields of DBstat struct to pointer value?
If it assigned pointer value, it seems like can collect database metric information in real time.
The text was updated successfully, but these errors were encountered: