-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/coordinator: run TryBots for older versions of Go on x/tools #39159
Comments
@dmitshur has just brought to my attention that the builders don't support Go versions before 1.13 currently, so we'd need to add that support first. Our current thinking is to support 2 years back, so Go 1.11 - present. We'd probably only need one Linux builder for each version, much like the Go 1.13 builder that runs now. |
As @stamblerre mentioned above (I was too slow to comment), we should consider how this would affect the support window for builders, if at all. At this time, we're able to stop supporting a builder that was needed for version Go 1.n as soon Go 1.n+2 is released. We don't always make use of this ability, but it enables to reduce maintenance costs sometimes. Some builders are less expensive/difficult to maintain than others. The Linux builder is one of the least difficult builder types to maintain and keep available for longer. I understand your current proposal is to make the Also /cc @andybons. Edit: I'll bring this up with the release team and discuss more with them. |
Thanks @dmitshur! I know how to write the code for this, but I guess it would have to wait until the infrastructure is there. Maybe, to start, we can add syntax to trigger TryBots for a specific version of Go manually (or does this already exist?). We will need this support before we make any progress on #39146, since without it, we're bound to regress. |
The CI that @findleyr set up (#39146 (comment)) has proven to be sufficient for this. I don't think we need this any longer, so closing. |
gopls
needs to have a more lenient policy than https://golang.org/doc/devel/release.html#policy, since it's fairly common for users to remain on older versions of Go and continue requiring an editor.We have historically broken
gopls
support for older Go versions (#39146) because TryBots with older Go versions do not run on x/tools. We are still undecided on how many Go versions to go back, but we do need this support.I'm happy to set this up myself, but I just wanted to file this issue in case there are any problems with this.
The text was updated successfully, but these errors were encountered: