Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/coordinator: run TryBots for older versions of Go on x/tools #39159

Closed
stamblerre opened this issue May 20, 2020 · 4 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@stamblerre
Copy link
Contributor

gopls needs to have a more lenient policy than https://golang.org/doc/devel/release.html#policy, since it's fairly common for users to remain on older versions of Go and continue requiring an editor.

We have historically broken gopls support for older Go versions (#39146) because TryBots with older Go versions do not run on x/tools. We are still undecided on how many Go versions to go back, but we do need this support.

I'm happy to set this up myself, but I just wanted to file this issue in case there are any problems with this.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 20, 2020
@gopherbot gopherbot added this to the Unreleased milestone May 20, 2020
@stamblerre stamblerre self-assigned this May 20, 2020
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 21, 2020
@stamblerre
Copy link
Contributor Author

@dmitshur has just brought to my attention that the builders don't support Go versions before 1.13 currently, so we'd need to add that support first. Our current thinking is to support 2 years back, so Go 1.11 - present. We'd probably only need one Linux builder for each version, much like the Go 1.13 builder that runs now.

/cc @cagedmantis @toothrot

@dmitshur
Copy link
Contributor

dmitshur commented May 21, 2020

As @stamblerre mentioned above (I was too slow to comment), we should consider how this would affect the support window for builders, if at all. At this time, we're able to stop supporting a builder that was needed for version Go 1.n as soon Go 1.n+2 is released. We don't always make use of this ability, but it enables to reduce maintenance costs sometimes.

Some builders are less expensive/difficult to maintain than others. The Linux builder is one of the least difficult builder types to maintain and keep available for longer.

I understand your current proposal is to make the linux/amd64 builder for Go 1.n available for the x/tools repository until Go 1.n+4 is released. Given there will be no more changes to release branches of those old Go versions, I don't foresee much additional maintenance that would need to be done to keep the builder operational, so this seems reasonable. I welcome thoughts from others.

Also /cc @andybons.

Edit: I'll bring this up with the release team and discuss more with them.

@stamblerre
Copy link
Contributor Author

Edit: I'll bring this up with the release team and discuss more with them.

Thanks @dmitshur! I know how to write the code for this, but I guess it would have to wait until the infrastructure is there. Maybe, to start, we can add syntax to trigger TryBots for a specific version of Go manually (or does this already exist?). We will need this support before we make any progress on #39146, since without it, we're bound to regress.

@stamblerre
Copy link
Contributor Author

stamblerre commented Oct 22, 2020

The CI that @findleyr set up (#39146 (comment)) has proven to be sufficient for this. I don't think we need this any longer, so closing.

@golang golang locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants