Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: duplicates comment after imports on every save #39147

Closed
heschi opened this issue May 19, 2020 · 0 comments
Closed

x/tools/gopls: duplicates comment after imports on every save #39147

heschi opened this issue May 19, 2020 · 0 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.2

Comments

@heschi
Copy link
Contributor

heschi commented May 19, 2020

https://golang.org/cl/233117 introduced a new bug where each save duplicates the comment immediately after the import block. I noticed this in go/packages/packages.go -- on every save a new copy of the "A LoadMode..." comment will be created.

@pjweinb
@heschi heschi added the gopls Issues related to the Go language server, gopls. label May 19, 2020
@heschi heschi added this to the gopls/v0.5.0 milestone May 19, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label May 19, 2020
@pjweinb pjweinb self-assigned this May 19, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 18, 2020
@kdeconinck kdeconinck mentioned this issue Dec 4, 2020
Closed
@golang golang locked and limited conversation to collaborators Jun 18, 2021
@rsc rsc unassigned pjweinb Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.2
Development

No branches or pull requests
4 participants
@pjweinb @stamblerre @gopherbot @heschi