Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp/regtest: TestRegenerateCgo fails in some environments #39135

Closed
findleyr opened this issue May 18, 2020 · 2 comments
Closed

x/tools/internal/lsp/regtest: TestRegenerateCgo fails in some environments #39135

findleyr opened this issue May 18, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Contributor

findleyr commented May 18, 2020 •
edited

After syncing to head, TestRegenerateCgo is failing on @bcmills machine. Relevant subsection of the logs (verbosity of test output was raised in #39130).

--- FAIL: TestRegenerateCgo (120.01s)
    --- FAIL: TestRegenerateCgo/singleton (60.00s)
        cgo_test.go:55: waiting on:
            	Unmet: empty diagnostics
            
            err:context deadline exceeded
            
            state:
            #### log messages (see RPC logs for full text):
            	Info: "2020/05/18 14:38:22 Build info\n----------\nversio...
            	Info: "2020/05/18 14:38:22 go env for /tmp/goplstest-sand...
            	Info: "2020/05/18 14:38:22 go/packages.Load\n\tsnapshot=0...
            	Info: "2020/05/18 14:38:23 go/packages.Load\n\tsnapshot=5...
            	Info: "2020/05/18 14:38:23 go/packages.Load\n\tsnapshot=5...
            	Info: "2020/05/18 14:38:52 background imports cache refre...
            	Info: "2020/05/18 14:38:52 background refresh finished af...
            
            #### diagnostics:
            	cgo.go (version 0):
            		(8, 9): fortytwo not declared by package C
            
            #### outstanding work:
        runner.go:202: Shutdown: Shutdown: context deadline exceeded

Something is racing: my guess is that this is a problem with detecting file changes. I'll look into it, and in the meantime t.Skip() the test.

CC @heschik @stamblerre
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 18, 2020
@gopherbot gopherbot added this to the Unreleased milestone May 18, 2020
@gopherbot
Copy link

Change https://golang.org/cl/234480 mentions this issue: internal/lsp/regtest: Skip failing/flaky TestRegenerateCgo

gopherbot pushed a commit to golang/tools that referenced this issue May 18, 2020
@findleyr
internal/lsp/regtest: Skip failing/flaky TestRegenerateCgo
4bde419 
Something is making this test deterministically fail in some
environments, such as @bcmills' desktop.

Skip it while I build go at tip and debug.

Updates golang/go#39135

Change-Id: I1bf8c55c5cfca471a904de85936f504313094807
Reviewed-on: https://go-review.googlesource.com/c/tools/+/234480
Run-TryBot: Robert Findley <rfindley@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
@findleyr
Copy link
Contributor Author

This turned out to be a problem with our internal GOPACKAGESDRIVER that affected both @bcmills and me. This also explains why it wasn't failing on the builders.

Closing in favor of our existing tracking bug.

@golang golang locked and limited conversation to collaborators May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr