Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gomote: gomote push confused by unclean GOROOT path #39104

Closed
prattmic opened this issue May 15, 2020 · 1 comment
Closed

x/build/cmd/gomote: gomote push confused by unclean GOROOT path #39104

prattmic opened this issue May 15, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@prattmic
Copy link
Member

Passing an unclean GOROOT to gomote causes it to add GOROOT to paths twice and then fail to look them up.

My GOROOT is /usr/local/google/home/mpratt/src/go. From /usr/local/google/home/mpratt/src/go/src, I run:

$ GOROOT=$(pwd)/../ gomote push user-mpratt-openbsd-amd64-64-0
...
Error running push: open /usr/local/google/home/mpratt/src/go/usr/local/google/home/mpratt/src/go/.git/COMMIT_EDITMSG: no such file or directory

Notice the whole GOROOT is on there twice. If I run this, it works fine:

$ GOROOT=$(readlink -f $(pwd)/../) gomote push user-mpratt-openbsd-amd64-64-0
...
2020/05/15 16:50:02 Uploading 9096 new/changed files; 22905838 byte .tar.gz

I imagine we need a path.Clean somewhere.
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 15, 2020
@prattmic prattmic added this to the Unplanned milestone May 15, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 15, 2020
@dmitshur dmitshur modified the milestones: Unplanned, Unreleased Aug 4, 2021
@gopherbot
Copy link

Change https://golang.org/cl/339929 mentions this issue: cmd/gomote: handle unclean GOROOT

@golang golang locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot