x/tools/gopls: decide if import statements should have definitions or links #39065
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
See microsoft/vscode-go#2614 for more context.
Ctrl + Click in VS Code is a shortcut for both jump to definition and opening a link. We provide links to https://pkg.go.dev for import statements, as well as definitions in the form of opening a window that shows the files in the package. The behavior is unintuitive because 2 things happen at once.
Currently, users can disable document links through the
go.experimentalLanguageServerFeatures
setting. Based on the response to microsoft/vscode#81520, my guess is that VS Code will not be fixing this any time soon, and even if they did, the only correct fix would be to change one of their shortcuts. Users are probably used to things working a specific way, so I doubt they would change a default shortcut, particularly since, in the majority of cases, definitions and document links don't collide.I propose that we create a
gopls
setting to choose between links and definitions for import statements. The default could be both. This way, users will not lose document links for other cases in which there are no collisions.The text was updated successfully, but these errors were encountered: