Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gerritbot: should determine author from first commit rather not last #38957

Open
dmitshur opened this issue May 8, 2020 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 8, 2020

When an imported PR has many commits, the Gerrit CL author is seemingly determined by taking the git author of the latest commit in the PR.

I think it may be better to take the git author of the first commit rather than last. That way, if an additional contributor adds more commits, the author of the CL would not change. The first commit seems like a more stable source for this information.

I noticed this in https://go-review.googlesource.com/c/go/+/216617/47..48 when I pushed a new merge commit to the end of https://github.com/golang/go/pull/36815/commits, and the author of the Gerrit CL changed.

/cc @golang/osp-team @griesemer

P.S. For bonus points, it can be considered to convert additional authors into "Co-authored-by" lines.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Community labels May 8, 2020
@dmitshur dmitshur added this to the Backlog milestone May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) Community FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant