Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/present: no section headers in Markdown syntax #38926

Open
jeanbza opened this issue May 7, 2020 · 6 comments
Open

x/tools/present: no section headers in Markdown syntax #38926

jeanbza opened this issue May 7, 2020 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@jeanbza
Copy link
Member

jeanbza commented May 7, 2020

IIRC we used to be able to use * and ** for section and subsection headers. It appears as though that's no longer the case: # terminates the content [1] (without an error...?), and ## is a subsection header.

Not sure if this is a bug or feature request.

1: As in, no header is displayed and no content is displayed after that point.
@gopherbot gopherbot added this to the Unreleased milestone May 7, 2020
@jeanbza
Copy link
Member Author

jeanbza commented May 7, 2020

@tbpg points out that https://go.googlesource.com/tools/+/refs/heads/master/present/parse.go#381 might be where this "stop reading more content" happens. (if I interpreted correctly)

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels May 8, 2020
@dmitshur
Copy link
Contributor

dmitshur commented May 8, 2020

Thanks for reporting @jadekler.

Is this about the new Markdown syntax or the legacy present syntax? The Markdown syntax was recently added in #33955.

@jeanbza
Copy link
Member Author

jeanbza commented May 11, 2020

The new markdown!

@dmitshur dmitshur removed the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label May 11, 2020
@dmitshur dmitshur changed the title x/blog: no section headers anymore x/tools/present: no section headers in Markdown syntax May 11, 2020
@dmitshur
Copy link
Contributor

/cc @rsc per owners.

@inianv
Copy link

inianv commented Feb 22, 2022

Is there an update on this @dmitshur @rsc. The problem still exists.

@jeanbza
Copy link
Member Author

jeanbza commented Feb 22, 2022

I had a CL that fixes it by changing the .md files at some point, but the "better" fix is to update the markdown parser. Never got around to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @jeanbza @gopherbot @inianv