Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: rare TestSpuriousWakeupsNeverHangSemasleep failures #38921

Closed
FiloSottile opened this issue May 7, 2020 · 5 comments
Closed

runtime: rare TestSpuriousWakeupsNeverHangSemasleep failures #38921

FiloSottile opened this issue May 7, 2020 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Milestone
Go1.18

Comments

@FiloSottile
Copy link
Contributor

Got one on the SlowBot for CL 227037.

https://storage.googleapis.com/go-build-log/9ee2139a/darwin-amd64-race_500ccc16.log

--- FAIL: TestSpuriousWakeupsNeverHangSemasleep (2.02s)
    semasleep_test.go:51: Program failed to return on time and has to be killed, issue #27520 still exists
FAIL
FAIL	runtime	80.585s

I am messing with the runtime in that CL but I don't see how it would be related to this, and I found two more in ~recent build dashboard logs.

greplogs -E TestSpuriousWakeupsNeverHangSemasleep -dashboard -l -md

2020-02-07T18:07:47-cb16d26/solaris-amd64-oraclerel
2019-10-31T21:53:06-5724348/darwin-amd64-10_10

Looks like it also failed during a release #37199 (comment) and in Sept 2019 for someone who then did not follow-up #27520 (comment).
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 11, 2020
@toothrot
Copy link
Contributor

/cc @randall77 @mikesmitty

@toothrot toothrot added this to the Backlog milestone May 11, 2020
@randall77
Copy link
Contributor

@odeke-em

Those other two errors you found grepping the logs look different. They are not timeouts.

I think we might need to just increase the timeout. If there is too much work going on on the machine, timers, or responses to them, might be delayed.

@bcmills
Copy link
Contributor

bcmills commented Nov 9, 2020

2020-11-05T22:14:40-8e5778e/linux-riscv64-jsing — signal: I/O possible
2020-10-12T15:38:05-2e7706d/darwin-amd64-race — Program failed to return on time and has to be killed
2020-08-18T08:47:48-4149493/solaris-amd64-oraclerel — signal: pollable Event
2020-06-17T15:09:07-f84bbd5/openbsd-arm-jsing — Program failed to return on time and has to be killed

@gopherbot
Copy link

Change https://golang.org/cl/367849 mentions this issue: runtime: give the subprocess more time in TestSpuriousWakeupsNeverHangSemasleep

@bcmills
Copy link
Contributor

bcmills commented Nov 30, 2021

This failure rate went way up after CL 366255, so I think it's now important to relax this test to reduce test flakiness.

greplogs --dashboard -md -l -e 'FAIL: TestSpuriousWakeupsNeverHangSemasleep' --since=2021-11-23

2021-11-29T22:02:49-1ab677a/netbsd-386-9_0-n2d
2021-11-29T19:24:34-68da368/linux-amd64-longtest
2021-11-27T23:29:50-0fa53e4/linux-amd64-longtest
2021-11-27T23:29:50-0fa53e4/linux-amd64-wsl
2021-11-27T01:14:21-fad67f8/netbsd-amd64-9_0-n2d
2021-11-26T13:18:11-7703804/linux-amd64-longtest
2021-11-26T13:18:11-7703804/solaris-amd64-oraclerel
2021-11-25T00:07:28-f7e34e7/solaris-amd64-oraclerel
2021-11-24T21:08:29-5527d7f/linux-amd64
2021-11-24T20:59:14-67dd9ee/solaris-amd64-oraclerel
2021-11-24T20:56:40-9e7600d/solaris-amd64-oraclerel
2021-11-24T20:54:07-6ea17aa/solaris-amd64-oraclerel
2021-11-24T20:51:25-5d8c49a/linux-amd64-longtest
2021-11-23T21:39:32-e3eaedb/linux-amd64-longtest
2021-11-23T19:31:05-0f64c21/solaris-amd64-oraclerel

@bcmills bcmills self-assigned this Nov 30, 2021
@bcmills bcmills added okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker labels Nov 30, 2021
@bcmills bcmills modified the milestones: Backlog, Go1.18 Nov 30, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. okay-after-beta1 Used by release team to mark a release-blocker issue as okay to resolve either before or after beta1 release-blocker
Projects
None yet
Milestone
Go1.18
Development

No branches or pull requests
5 participants
@toothrot @FiloSottile @bcmills @randall77 @gopherbot