Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include fix for #34437 in Go 1.14 release notes [1.14 backport] #38904

Closed
gopherbot opened this issue May 6, 2020 · 3 comments
Closed

doc: include fix for #34437 in Go 1.14 release notes [1.14 backport] #38904

gopherbot opened this issue May 6, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.14.9

Comments

@gopherbot
Copy link

@dmitshur requested issue #38801 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open an issue to backport this to Go 1.14 when the fix is available. This is a documentation fix.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 6, 2020
@gopherbot gopherbot mentioned this issue May 6, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.3 milestone May 6, 2020
@andybons andybons modified the milestones: Go1.14.3, Go1.14.4 May 14, 2020
@andybons
Copy link
Member

Approved (even though the original issue is not closed) as this is a documentation fix.

@andybons andybons added the CherryPickApproved Used during the release process for point releases label May 27, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 27, 2020
@dmitshur dmitshur modified the milestones: Go1.14.4, Go1.14.5 Jun 1, 2020
@andybons andybons modified the milestones: Go1.14.5, Go1.14.6, Go1.14.7 Jul 14, 2020
@toothrot toothrot modified the milestones: Go1.14.7, Go1.14.8 Aug 6, 2020
@dmitshur dmitshur modified the milestones: Go1.14.8, Go1.14.9 Sep 1, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/252617 mentions this issue: [release-branch.go1.14] doc/go1.14: document json.Umarshal map key support of TextUnmarshaler

@gopherbot
Copy link
Author

Closed by merging 404635c to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Sep 2, 2020
@ToastCheng @cagedmantis
[release-branch.go1.14] doc/go1.14: document json.Umarshal map key su…
404635c 
…pport of TextUnmarshaler

Document that json.Unmarshal supports map keys whose underlying
types implement encoding.TextUnmarshaler.

Updates #38801.
Fixes #38904.

Change-Id: Icb9414e9067517531ba0da910bd4a2bb3daace65
Reviewed-on: https://go-review.googlesource.com/c/go/+/237857
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
(cherry picked from commit 47b4509)
Reviewed-on: https://go-review.googlesource.com/c/go/+/252617
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.14.9
Development

No branches or pull requests
4 participants
@toothrot @andybons @dmitshur @gopherbot