Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: TestMarshalUnmarshal failures starting around 2020-05-06 #38902

Closed
bcmills opened this issue May 6, 2020 · 3 comments
Closed

crypto/tls: TestMarshalUnmarshal failures starting around 2020-05-06 #38902

bcmills opened this issue May 6, 2020 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone
Go1.15

Comments

@bcmills
Copy link
Contributor

bcmills commented May 6, 2020

2020-05-06T01:27:05-fdb8a3e/freebsd-386-11_2

--- FAIL: TestMarshalUnmarshal (0.00s)
    handshake_messages_test.go:61: #9 failed to unmarshal &tls.sessionState{vers:0x304, cipherSuite:0x1bbc, masterSecret:[]uint8{0x9e, 0xee, 0xa6, 0xfe, 0x29, 0xf9, 0x58, 0x93, 0x29, 0xc0, 0x61, 0x5, 0x23, 0x6b, 0xc0, 0x5d, 0x5e, 0xee, 0xfd, 0x6, 0x22, 0x55, 0x8, 0x55, 0x3e, 0xe5, 0xd0, 0xfa, 0xb8, 0x9b, 0xd0, 0x2, 0x23, 0x3f, 0x6a, 0xbd, 0x6a, 0xf1, 0x77, 0xec, 0x1c, 0x8e, 0xe0, 0xc9, 0x53, 0xa4, 0xe0, 0x95, 0xec, 0x25, 0xee, 0x70, 0x4b, 0x4f, 0x7b, 0xfc, 0x6a, 0x4b, 0x1b, 0x1b, 0xe9, 0x67, 0xd5, 0x58, 0x1, 0xb0, 0xa2}, certificates:[][]uint8{[]uint8{0xb1, 0x3d, 0x7a, 0x39, 0x5b, 0xd8, 0xa9, 0xd1, 0x9, 0x83, 0xe5, 0xf2, 0x25, 0xc9, 0x33, 0xc4, 0xaf, 0x32, 0x16, 0x56, 0x68, 0x52, 0x8, 0x2f, 0xb0, 0xde, 0xf, 0xde, 0xa5, 0x95, 0x70, 0xb1, 0xe6, 0x60, 0x4d, 0x8f, 0xb9, 0x59, 0x55, 0x5f, 0x93, 0x45, 0xbf, 0x28, 0x7, 0x13, 0xb1, 0x17, 0xa, 0x26, 0xac, 0x91, 0x55, 0xe2, 0x9, 0x2c, 0x1, 0xd8, 0x6, 0x44, 0x35, 0x55, 0x5c, 0x77, 0x76, 0x39, 0xdb, 0x55, 0x50, 0xb8, 0x29, 0x3, 0xc5, 0xb2, 0x5, 0x69, 0xb9, 0xc2, 0x21, 0x7e, 0x62, 0x5c, 0xa4, 0x12, 0x99, 0x3e, 0xea, 0xa, 0xaa, 0x1e, 0xb7, 0x76, 0xaf, 0x2d, 0x45, 0xa2, 0xfb, 0xe6, 0x22, 0xda, 0xa6, 0xe5, 0x9e, 0xf1, 0x35, 0x9f, 0xa3, 0x78, 0xbd, 0xd9, 0x8f, 0x2d, 0xfe, 0x22, 0xe9, 0x2d, 0x3e, 0x4f, 0xb5, 0x37, 0x53, 0x7e, 0x9a, 0x6d, 0x60, 0xd0, 0x4c, 0x9a, 0xb0, 0x55, 0x3c, 0x8b, 0xb3, 0x71, 0x85, 0x97, 0x7e, 0x5d, 0xc5, 0xba, 0xea, 0xe0, 0x99, 0xdd, 0xe5, 0xd0, 0x6f, 0x30, 0x87, 0xd5, 0x66, 0x7c, 0x4b, 0x3e, 0x28, 0x1, 0x36, 0x7b, 0xe1, 0x8a, 0x88, 0xb3, 0x9f, 0xd4, 0xfc, 0x9c, 0xfe, 0x42, 0xc6, 0x72, 0x28, 0x88, 0xa4, 0xc6, 0xb6, 0x79, 0xdb, 0xdb, 0xcb, 0xba, 0x1, 0xad, 0xf2, 0xba, 0xcd, 0xbf, 0x49, 0x44, 0x8e, 0x9d, 0xed, 0xa6, 0x2c, 0xf8, 0x8c, 0x35, 0xaf, 0x3d, 0x85, 0x7e, 0x9b, 0x67, 0x3e, 0x42, 0x88, 0x65, 0xef, 0x3c, 0x5e, 0xdb, 0x9}}, usedOldKey:false} 03041bbc00439eeea6fe29f9589329c06105236bc05d5eeefd06225508553ee5d0fab89bd002233f6abd6af177ec1c8ee0c953a4e095ec25ee704b4f7bfc6a4b1b1be967d55801b0a200d7000000d3b13d7a395bd8a9d10983e5f225c933c4af3216566852082fb0de0fdea59570b1e6604d8fb959555f9345bf280713b1170a26ac9155e2092c01d8064435555c777639db5550b82903c5b20569b9c2217e625ca412993eea0aaa1eb776af2d45a2fbe622daa6e59ef1359fa378bdd98f2dfe22e92d3e4fb537537e9a6d60d04c9ab0553c8bb37185977e5dc5baeae099dde5d06f3087d5667c4b3e2801367be18a88b39fd4fc9cfe42c6722888a4c6b679dbdbcbba01adf2bacdbf49448e9deda62cf88c35af3d857e9b673e428865ef3c5edb09
FAIL
FAIL	crypto/tls	1.152s

Marking as release-blocker for Go 1.15 in case this is an x/crypto regression pulled in via CL 231657.

CC @FiloSottile @katiehockman @dmitshur
@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels May 6, 2020
@bcmills bcmills added this to the Go1.15 milestone May 6, 2020
@FiloSottile FiloSottile changed the title x/crypto/tls: failure in TestMarshalUnmarshal on freebsd-386-11_2 builder crypto/tls: failure in TestMarshalUnmarshal on freebsd-386-11_2 builder May 8, 2020
@bcmills
Copy link
Contributor Author

bcmills commented May 18, 2020

Does not appear to be platform-specific.

2020-05-15T16:15:25-2b70ffe/linux-386-longtest
2020-05-08T20:57:01-f1ac85c/linux-amd64
2020-05-08T20:24:33-8f4be42/linux-386
2020-05-08T02:17:26-62a3f2e/windows-amd64-2016
2020-05-06T19:03:06-641918e/linux-386-longtest
2020-05-06T16:20:51-33249f4/linux-amd64-fedora
2020-05-06T01:27:05-fdb8a3e/freebsd-386-11_2

@bcmills bcmills changed the title crypto/tls: failure in TestMarshalUnmarshal on freebsd-386-11_2 builder crypto/tls: TestMarshalUnmarshal failures starting around 2020-05-06 May 18, 2020
@FiloSottile
Copy link
Contributor

Looks like a rare random edge case in sessionState serialization, probably due to @katiehockman's change.

@gopherbot
Copy link

Change https://golang.org/cl/234486 mentions this issue: crypto/tls: remove version check when unmarshaling sessionState

@golang golang locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
4 participants
@FiloSottile @bcmills @gopherbot @katiehockman