-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: stuck with error after resolving git conflict markers #38879
Comments
Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here. |
Seeing error messages like
which leads me to believe that this is a duplicate of #38878, which is in turn a duplicate of #38423 (and probably related to #38358). |
Got it. It's pretty hard to understand what the cause of a bug is and therefore know if it's a dupe, sorry. As an aside, is there no way for gopls to report itself as broken so that things don't get stuck, and maybe an error message bubbles up to VSCode? |
No worries - I appreciate you filing all of these issues with logs. We can probably use a |
I just got the error again, after restarting gopls. In other words:
I wasn't sure if the bug in the other issues related to new files appearing while gopls was running, or just changes in test files. |
Thanks for the report. It looks like we're failing to load a package from a file, but we don't log any errors. I added a better error log in https://golang.org/cl/230315, so when that's merged it would be easier to figure out why this happens. |
I suspect this is a dupe of the transitive invalidation bug? |
Yes, probably true. Should be fixed in |
What did you do?
Did a
git rebase
and resolved conflict markers in a file.What did you expect to see?
No errors.
What did you see instead?
gopls thinks there are still conflict markers.
Log
gopls.log.gz, scrubbed of
didOpen
sources, except for the file in question,source_test.go
.Build info
Go info
The text was updated successfully, but these errors were encountered: