Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: update for driver.ObjTool interface change #38802

Closed
dmitshur opened this issue May 1, 2020 · 4 comments
Closed

cmd/pprof: update for driver.ObjTool interface change #38802

dmitshur opened this issue May 1, 2020 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.16

Comments

@dmitshur
Copy link
Contributor

dmitshur commented May 1, 2020 •
edited

The driver.ObjTool interface has changed in google/pprof@b1a9688 as follows:

 	// Disasm disassembles the named object file, starting at
 	// the start address and stopping at (before) the end address.
-	Disasm(file string, start, end uint64) ([]Inst, error)
+	Disasm(file string, start, end uint64, intelSyntax bool) ([]Inst, error)

In order to be able to update to a newer version of github.com/google/pprof dependency (part of #36905), we need to know how to update the objTool.Disasm method to conform to the new signature.

@hyangah, can you tell if we should use the intelSyntax value in some way, or should it be unused?

/cc @hyangah @wyk9787 @aalexand
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 1, 2020
@dmitshur dmitshur added this to the Go1.15 milestone May 1, 2020
@gopherbot
Copy link

Change https://golang.org/cl/231657 mentions this issue: all: update module dependencies

@dmitshur
Copy link
Contributor Author

dmitshur commented May 1, 2020

I mentioned this issue as a TODO comment in CL 231657.

@dmitshur
Copy link
Contributor Author

dmitshur commented May 1, 2020

I've realized the scope of #36905 is to update golang.org/x/... dependencies only, external ones are out of scope. So I'll leave the update to github.com/google/pprof out of CL 231657 and set the milestone here to be Backlog.

@dmitshur dmitshur modified the milestones: Go1.15, Backlog May 1, 2020
@gopherbot
Copy link

Change https://golang.org/cl/248499 mentions this issue: cmd/vendor,cmd/pprof: sync pprof@1a94d8640e99

@dmitshur dmitshur modified the milestones: Backlog, Go1.16 Sep 22, 2020
@golang golang locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.16
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot